feat(express): implement EdDSA commitments for external signer #3661
+234
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alebusse
force-pushed
the
WP-94-implement-externalSigner-for-eddsa-with-commitments
branch
from
d9aa01f
to
a5d73dd
Compare
alebusse
force-pushed
the
WP-94-implement-externalSigner-for-eddsa-with-commitments
branch
from
a5d73dd
to
1cd350b
Compare
alebusse
force-pushed
the
WP-94-implement-externalSigner-for-eddsa-with-commitments
branch
2 times, most recently
from
e732111
to
1ba74f0
Compare
alebusse
force-pushed
the
WP-94-implement-externalSigner-for-eddsa-with-commitments
branch
from
1ba74f0
to
d468e16
Compare
sachushaji
reviewed
Jun 26, 2023
islamaminBitGo
previously approved these changes
Jun 27, 2023
|
This change has been tested. LGTM |
|
|
||
| const signerShare = signingKey.yShares[bitgoIndex].u + signingKey.yShares[bitgoIndex].chaincode; | ||
| const bitgoGpgKey = await getBitgoGpgPubKey(this.bitgo); | ||
| const bitgoToUserEncryptedSignerShare = await encryptText(signerShare, bitgoGpgKey); |
There was a problem hiding this comment.
nit: I think this should be userToBitgoEncryptedSignerShare
alebusse
force-pushed
the
WP-94-implement-externalSigner-for-eddsa-with-commitments
branch
from
d468e16
to
2a38dba
Compare
implemented EdDSA commitment step for external signer added unit test WP-94
alebusse
force-pushed
the
WP-94-implement-externalSigner-for-eddsa-with-commitments
branch
from
2a38dba
to
52ccfe7
Compare
islamaminBitGo
approved these changes
Jun 27, 2023
zahin-mohammad
approved these changes
Jun 27, 2023
alebusse
deleted the
WP-94-implement-externalSigner-for-eddsa-with-commitments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented EdDSA commitment step for external signer added unit test
WP-94